fix: implement graceful shutdown to prevent db connection leaks#344
Merged
gboigwe merged 1 commit intoThinkLikeAFounder:mainfrom Mar 28, 2026
Merged
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308
Overview
This PR addresses a critical connection leak where
process.exit(1)was terminating the production backend during DB connection faults or orchestrator restarts without systematically closing active databases. During crash loops, this was preventing dead connections from being returned and rapidly exhausting the Postgres pool threshold limit.Changes Implemented
Centralized Teardown Routine
Created an async
shutdown(code)mechanism that systematically disconnects all persistent endpoints properly inside a safetry/catch.Fixed
exit(1)LeaksReplaced abrupt
process.exit(1)calls acrossindex.ts(specifically inside DB/Prisma health checks andstart()catch loops) withawait shutdown(1)inside production environments to intercept and close connections before faulting.Corrected Issue Misconceptions (Missing Handlers)
The originating issue asserted that
process.on('SIGTERM')handlers already existed natively and only selectively missed the error paths. This was incorrect — no graceful signal handlers were bound. Fully functioningSIGTERMandSIGINTapplication handlers have now been globally established.Added HTTP Server & Redis Drain
The teardown safely waits for
server.close()to stop fetching in-flight requests, and gracefully disconnectsredisClient.quit()alongside Prisma and the Postgres pg pool viaawait pool.end().Testing
O(1)scope-limited teardown routines ensure no cross-contamination inside or outside of production.